Remove warning message passing multi-class object to Rclusterpp.hclust#14
Open
bmbroom wants to merge 4 commits intonolanlab:masterfrom
Open
Remove warning message passing multi-class object to Rclusterpp.hclust#14bmbroom wants to merge 4 commits intonolanlab:masterfrom
bmbroom wants to merge 4 commits intonolanlab:masterfrom
Conversation
class(x) returns a character vector. When that vector was longer than one, the original code just checked the first element for a match to "dist" and issued a warning. Happens in common case where x is a matrix (and array). This patch removes the warning for objects with multiple classes. It also fixes a bug when object's first class is not "dist" but a subsequent one is.
rbruggner
approved these changes
Apr 22, 2022
rbruggner
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small patch to remove warning message when you pass a matrix to Rclusterpp.hclust.