Run specs for files outside the 'app' folder#19
Open
emilianoLeite wants to merge 2 commits intonoku:masterfrom
Open
Run specs for files outside the 'app' folder#19emilianoLeite wants to merge 2 commits intonoku:masterfrom
emilianoLeite wants to merge 2 commits intonoku:masterfrom
Conversation
added 2 commits
February 26, 2018 20:06
With this change, specs for files in unconventional folders (like 'lib') will also be found (as long as the spec path mirrors the impl. path).
I had some trouble figuring out how to run the tests (I was running `npm test` in the terminal and getting a cryptic error message), so I wrote this mini CONTRIBUTING guide, to help new developers.
|
@noku I would like to see this change merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, specs for files in unconventional folders (like
lib) will also be found (as long as the spec path mirrors the impl. path).I also wrote a mini CONTRIBUTING guide to help new developers.