fix: assert signature is normalized instead of reducing it#14
Open
TomAFrench wants to merge 3 commits intomasterfrom
Open
fix: assert signature is normalized instead of reducing it#14TomAFrench wants to merge 3 commits intomasterfrom
TomAFrench wants to merge 3 commits intomasterfrom
Conversation
Change normalize_signature to assert_normalized_signature which now asserts the input is already in range [0, BN254_Fq_MODULUS) rather than reducing it. This removes the need for the quotient computation and simplifies the modulus constant to a single tuple.
Previously only sig_e was validated to be in range [0, BN254_Fq_MODULUS). A malicious signature could use sig_s values >= modulus that would be reduced internally, allowing multiple valid signatures for the same message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.