Conversation
asterite
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
This should allow noir-lang/noir#10736 to be merged
Summary*
Changes the visibility of
JSON::compute_keyhash_and_sort_json_entriesfrom private topub(crate), to allow it to be called fromJSON::parse_jsonwith the changes noir-lang/noir#10736 introduces.Additional Context
The
compute_keyhash_and_sort_json_entriesis defined in thekeymapmodule, while theJSONstructure and theparse_jsonmethod are in thejsonmodule. Thekeymapandjsonmodules are siblings, so they shouldn't see each others' privates. There was a loophole for impl blocks, where they acted as if we were in the same type, regardless of the surrounding module, but this is not correct (or at least not how Rust works; it makes it harder for modules to isolate their functionality from each other).PR Checklist*
cargo fmton default settings.