Skip to content

Fix: False positives on the folder name #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erwansturzenegger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: False positives on the folder name #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions AutoDerivPlugin/src/net/nodj/autoderivplugin/rules/TreeRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,20 @@ public void applyOnResource(IResource res, IProgressMonitor progress) {
fits = member.equals(res);
break;
case IResource.PROJECT:
//If same project -> true
fits = res.getProject().equals(member);
break;
case IResource.ROOT:
fits = true;
break;
case IResource.FOLDER :
IFolder f = (IFolder) member;
// info("TreeRule.applyOnResource() a " + f.exists(res.getLocation()));
// info("TreeRule.applyOnResource() b " + f.exists(res.getFullPath()));
IPath rp = res.getProjectRelativePath();
IPath fp = f.getProjectRelativePath();
// info("TreeRule.applyOnResource() c " + fp.isPrefixOf(rp));
// info("TreeRule.applyOnResource() d " + (f.findMember(res.getLocation()) != null));
fits = fp.isPrefixOf(rp);

//Can be true only if the two folders are in the same project
boolean sameProject = res.getProject().equals(member.getProject());
fits = fp.isPrefixOf(rp) && sameProject;
break;
default:
// should not happen: resource is not supposed to be a project or /
Expand Down