Skip to content

Add next 5 upcoming meet_ups#11

Open
codingCookie wants to merge 3 commits intonodeschool:gh-pagesfrom
codingCookie:gh-pages
Open

Add next 5 upcoming meet_ups#11
codingCookie wants to merge 3 commits intonodeschool:gh-pagesfrom
codingCookie:gh-pages

Conversation

@codingCookie
Copy link
Copy Markdown

connects to #8

I grabed the issue because i haven't done anything yet with the meetupAPI - and i like nodeschool :)

First i tried to get the events via an JS Fetch command - but i run into 'Allow-Origin'-problems.
My second idea was to use an express-server to get everything on the server - and not the client - and yay it works :) The only disadvantage is that you have to add an API_Key from meetUp (http://www.meetup.com/de-DE/meetup_api/auth/#keysign) - I had no idea how to hide it :/
Maybe you have one?

I hope you like my idea and implementation.

++ package.json, express & handlebars-template-engine to show upcoming meet_up's

TODO: add a valid API_KEY to server.js
INFO: start with > node server.js

…o show upcoming meet ups

TODO: add a valid API_KEY to server.js
INFO: start page with > node server.js
@newswim
Copy link
Copy Markdown
Collaborator

newswim commented Oct 23, 2016

Hi @codingCookie !

Very cool of you to donate your time and energy to jumping in on our issue queue. This implementation looks great, there are just a couple things I'd like for us to consider before taking steps to converting this project into a node app.

First, the current site is hosted on GitHub Pages, which is (as you most likely know) a free service that builds and deploys whenever you push a static site (or Jekyll project) to the gh-pages branch. As far as I'm aware, there's not a way to currently do things like hiding API keys within the GitHub Pages deployment environment. This would be great, and would likely be configured through the repo's 'Settings' menu - it's unfortunate that this feature doesn't currently exist. However, this particular API key would be difficult to abuse and is easily rehashed by meetup, though it's still probably not great practice.

The other consideration is cost of hosting. I know that at one point there were a few free services, but many of these seem to have transitioned away from offering a free tier. Do you know of any?

I noticed your initial attempt was using Fetch - it would be nice to figure out a fix for the CORS issue since that seems to always cause trouble and having a reliable pattern would be nice as Fetch is only going to become more commonly used. Note, since IE still has no support whatsoever, you'll likely have to use a polyfill.

One last thing - I think this is really cool and I really appreciate your contribution. It makes sense that a NodeSchool website would be hosted as a Node app. Thank you!

@codingCookie
Copy link
Copy Markdown
Author

Hi @newswim,

thanks for your lines.
As far as I know - Heroku has still free tiers.
I googled around but I can't find something working with fetch - I will ask a colleague tomorrow - maybe he has an idea.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants