Skip to content

Conversation

@mcollina
Copy link
Member

Summary

  • Fixed test/fetch/client-error-stack-trace.js which was hardcoding undici as the expected folder name in stack traces
  • The test now dynamically determines the project folder name using path.basename(), allowing it to pass when the repo is cloned to a differently-named directory

Test plan

  • Verified the test passes with npx borp -p "test/fetch/client-error-stack-trace.js"

🤖 Generated with Claude Code

The test was hardcoding 'undici' as the expected folder name in stack
traces, which fails when the repo is cloned to a differently-named
directory. Now dynamically determines the project folder name.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (59fd5f4) to head (bc8697e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4707      +/-   ##
==========================================
+ Coverage   92.85%   92.87%   +0.01%     
==========================================
  Files         109      109              
  Lines       33809    33809              
==========================================
+ Hits        31395    31401       +6     
+ Misses       2414     2408       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina requested a review from ronag December 23, 2025 07:26
@mcollina mcollina merged commit ec4a84e into main Dec 25, 2025
33 of 35 checks passed
@mcollina mcollina deleted the fix/client-error-stack-trace-folder-name branch December 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants