-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: adjust ui-components publishing #8620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8620 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 103 103
Lines 9068 9068
Branches 314 314
=======================================
Hits 6807 6807
Misses 2259 2259
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adjusts how @node-core/ui-components is built and published so releases are driven by CI with pnpm publish, and the package can expose dist/ artifacts via conditional exports/imports.
Changes:
- Update
@node-core/ui-componentsexports/imports, addfileswhitelist for publishingdist/, and simplifyreleaseto build-only. - Add
customConditionsto TypeScript configs (apps/site and ui-components). - Update the publish workflow to always run
pnpm publishafter an optionalreleasescript.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/tsconfig.json | Tweaks TS module resolution settings and enables declaration emit. |
| packages/ui-components/scripts/publish.mjs | Removes the per-package publish script (publishing handled elsewhere now). |
| packages/ui-components/package.json | Introduces conditional exports/imports, adds files for publish contents, adjusts release/build scripts. |
| apps/site/tsconfig.json | Adds customConditions for TS resolution behavior. |
| .github/workflows/publish-packages.yml | Ensures CI runs pnpm publish after running release when present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
| "compile": "node --run compile:ts && node --run compile:css", | ||
| "release": "node --run compile && node scripts/publish.mjs", | ||
| "compile:watch": "node --run compile:ts -- --watch & node --run compile:css -- --watch", | ||
| "release": "node --run compile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, we can just remove release and tell GitHub Actions to run compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, Im, fine with this :)
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this greatly increase the package size, as we are now providing multiple copies of the code?
How does this greatly increase package size? Only dist is being bundled. As it was before (https://github.com/nodejs/nodejs.org/pull/8620/changes#diff-ed54e778b1263cc888fe4a18544602094a59e7a7b57e749729088f9fc2d8ef6fR107-R110) |
Added local development instructions for using the package via npm link. Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Summary
Testing