Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 11, 2026

Summary

  • remove ui-components publish script and publish from repo root
  • update ui-components exports/imports and release script to use dist for rolldown
  • add customConditions to apps/site and ui-components tsconfig
  • include dist in publish files
  • ensure workflow runs pnpm publish after release

Testing

  • pnpm lint:types

Copilot AI review requested due to automatic review settings February 11, 2026 13:58
@ovflowd ovflowd requested review from a team as code owners February 11, 2026 13:58
@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 11, 2026 9:26pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.06%. Comparing base (d2e5cd2) to head (1bdab23).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8620   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files         103      103           
  Lines        9068     9068           
  Branches      314      314           
=======================================
  Hits         6807     6807           
  Misses       2259     2259           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts how @node-core/ui-components is built and published so releases are driven by CI with pnpm publish, and the package can expose dist/ artifacts via conditional exports/imports.

Changes:

  • Update @node-core/ui-components exports/imports, add files whitelist for publishing dist/, and simplify release to build-only.
  • Add customConditions to TypeScript configs (apps/site and ui-components).
  • Update the publish workflow to always run pnpm publish after an optional release script.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/ui-components/tsconfig.json Tweaks TS module resolution settings and enables declaration emit.
packages/ui-components/scripts/publish.mjs Removes the per-package publish script (publishing handled elsewhere now).
packages/ui-components/package.json Introduces conditional exports/imports, adds files for publish contents, adjusts release/build scripts.
apps/site/tsconfig.json Adds customConditions for TS resolution behavior.
.github/workflows/publish-packages.yml Ensures CI runs pnpm publish after running release when present.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.74 MB
New Total Size 3.74 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/2fa6bd6f857d0abe.js 207.34 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/42bb8307ca53d9f6.js 207.34 KB

"compile": "node --run compile:ts && node --run compile:css",
"release": "node --run compile && node scripts/publish.mjs",
"compile:watch": "node --run compile:ts -- --watch & node --run compile:css -- --watch",
"release": "node --run compile",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we can just remove release and tell GitHub Actions to run compile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, Im, fine with this :)

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this greatly increase the package size, as we are now providing multiple copies of the code?

@ovflowd
Copy link
Member Author

ovflowd commented Feb 11, 2026

Doesn't this greatly increase the package size, as we are now providing multiple copies of the code?

How does this greatly increase package size? Only dist is being bundled. As it was before (https://github.com/nodejs/nodejs.org/pull/8620/changes#diff-ed54e778b1263cc888fe4a18544602094a59e7a7b57e749729088f9fc2d8ef6fR107-R110)

Added local development instructions for using the package via npm link.

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants