Skip to content

module: fix extensionless entry with explicit type=commonjs #61600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 5 commits into
base: main
Choose a base branch
from
+78 −0
Open

module: fix extensionless entry with explicit type=commonjs #61600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27ba1cb
test: add regression for extensionless ESM under type=commonjs
inoway46 Jan 31, 2026
682ec4f
module: handle extensionless entry with explicit type=commonjs
inoway46 Jan 31, 2026
06a7ad2
test: remove unnecessary node:test wrapper from single test
inoway46 Feb 1, 2026
98a519b
test: use spawnSyncAndAssert in extensionless ESM test
inoway46 Feb 1, 2026
79cdbd0
test: cover extensionless ESM with explicit module type
inoway46 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,6 +1929,15 @@ Module._extensions['.js'] = function(module, filename) {
} else {
format = 'typescript';
}
} else if (path.extname(filename) === '') {
// Extensionless files skip the .js suffix check above. When type is explicit,
// follow it so ESM syntax surfaces as SyntaxError for commonjs instead of
// silently delegating to ESM.
pkg = packageJsonReader.getNearestParentPackageJSON(filename);
const typeFromPjson = pkg?.data?.type;
if (typeFromPjson === 'commonjs' || typeFromPjson === 'module') {
format = typeFromPjson;
}
}
const { source, format: loadedFormat } = loadSource(module, filename, format);
// Function require shouldn't be used in ES modules when require(esm) is disabled.
Expand Down
69 changes: 69 additions & 0 deletions test/es-module/test-extensionless-esm-type-commonjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
'use strict';

const fs = require('node:fs');
const path = require('node:path');
const { spawnSyncAndAssert } = require('../common/child_process');
const tmpdir = require('../common/tmpdir');

tmpdir.refresh();

const commonjsDir = tmpdir.resolve('extensionless-esm-commonjs');
fs.mkdirSync(commonjsDir, { recursive: true });

// package.json with type: commonjs
fs.writeFileSync(
path.join(commonjsDir, 'package.json'),
'{\n "type": "commonjs"\n}\n',
'utf8'
);

// Extensionless executable with shebang + ESM syntax.
// NOTE: Execute via process.execPath to avoid PATH/env differences.
const commonjsScriptPath = path.join(commonjsDir, 'script'); // no extension
fs.writeFileSync(
commonjsScriptPath,
'#!/usr/bin/env node\n' +
"console.log('script STARTED')\n" +
"import { version } from 'node:process'\n" +
'console.log(version)\n',
'utf8'
);
fs.chmodSync(commonjsScriptPath, 0o755);

spawnSyncAndAssert(process.execPath, ['./script'], {
cwd: commonjsDir,
encoding: 'utf8',
}, {
status: 1,
stderr: /.+/,
trim: true,
});

const moduleDir = tmpdir.resolve('extensionless-esm-module');
fs.mkdirSync(moduleDir, { recursive: true });

// package.json with type: module
fs.writeFileSync(
path.join(moduleDir, 'package.json'),
'{\n "type": "module"\n}\n',
'utf8'
);

const moduleScriptPath = path.join(moduleDir, 'script'); // no extension
fs.writeFileSync(
moduleScriptPath,
'#!/usr/bin/env node\n' +
"console.log('script STARTED')\n" +
"import { version } from 'node:process'\n" +
'console.log(version)\n',
'utf8'
);
fs.chmodSync(moduleScriptPath, 0o755);

spawnSyncAndAssert(process.execPath, ['./script'], {
cwd: moduleDir,
encoding: 'utf8',
}, {
stdout: /script STARTED[\s\S]*v\d+\./,
trim: true,
});