module: fix extensionless entry with explicit type=commonjs #61600
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
joyeecheung
reviewed
Jan 31, 2026
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Thanks for the PR, a couple of comments, otherwise this looks good.
|
|
||
| const tmpdir = require('../common/tmpdir'); | ||
|
|
||
| test('extensionless entry point with ESM syntax under type=commonjs should not silently exit 0', () => { |
Member
There was a problem hiding this comment.
There is no need to use node:test if there is only one test - it would unnecessarily clutter the CI output with nested tap (and if more tests are added they should be in separate files to avoid building test monoliths).
| ); | ||
| fs.chmodSync(scriptPath, 0o755); | ||
|
|
||
| const r = spawnSync(process.execPath, ['./script'], { |
Member
There was a problem hiding this comment.
Can you use spawnSyncAndAssert from test/common/child_process.js for this? Otherwise when the expectation is not met in the CI there won't be a lot of information about what's going on.
| // instead of silently delegating to ESM. | ||
| pkg = packageJsonReader.getNearestParentPackageJSON(filename); | ||
| if (pkg?.data?.type === 'commonjs') { | ||
| format = 'commonjs'; |
Member
There was a problem hiding this comment.
N/B: I think we should also allow passing the explicit "module" type field in package.json here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an extensionless entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing any error. This happened because extensionless files skip the
.jssuffix check in the CJS loader, so the explicittype: commonjswas not being enforced, allowing ESM syntax to be silently delegated to ESM loading which never completed before the process exited.This change ensures the CJS loader treats extensionless entry points as commonjs when
typeis explicitly set to "commonjs" in package.json, forcing ESM syntax to surface as a SyntaxError instead of silently exiting.Fixes: #61104
Related: #61171 (alternative approach)