Skip to content

Conversation

@kimtaejin3
Copy link
Contributor

This PR fixes array elements being incorrectly classified as "argument" in ERR_INVALID_ARG_TYPE and
ERR_INVALID_ARG_VALUE error messages.

for example:

Buffer.concat([1]);     

Before:
The "list[0]" argument must be an instance of Buffer or Uint8Array.

After:
The "list[0]" property must be an instance of Buffer or Uint8Array.

Updated related test expectations in:

  • test-buffer-concat.js
  • test-diff.js
  • test-dns-setservers-type-check.js
  • test-process-setgroups.js
  • test-tls-set-default-ca-certificates-error.js

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (f6464c5) to head (3a5b9f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61599      +/-   ##
==========================================
- Coverage   89.76%   89.68%   -0.09%     
==========================================
  Files         673      673              
  Lines      203944   203927      -17     
  Branches    39191    39131      -60     
==========================================
- Hits       183080   182897     -183     
- Misses      13194    13341     +147     
- Partials     7670     7689      +19     
Files with missing lines Coverage Δ
lib/internal/errors.js 97.62% <100.00%> (+<0.01%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants