test_runner: exclude ignored lines from BRDA in lcov output #61598
+75
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `/* node:coverage ignore next */` comments, the coverage system correctly excluded lines from DA (line coverage) entries in LCOV output but still reported branches as uncovered (BRDA count=0). This caused branch coverage to show incorrect percentages (e.g., 66% instead of 100%) when the uncovered branch path contained ignored lines, impacting CI/CD pipelines that enforce branch coverage thresholds. The fix treats branches as covered when they have `count === 0` but contain ignored lines (`ignoredLines > 0`). This matches the behavior of c8 and ensures ignored code doesn't penalize branch coverage. Fixes: nodejs#61586
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
/* node:coverage ignore next */comments, the coverage system correctly excluded lines from DA (line coverage) entries in LCOV output but still reported branches as uncovered (BRDA count=0).This caused branch coverage to show incorrect percentages (e.g., 66% instead of 100%) when the uncovered branch path contained ignored lines, impacting CI/CD pipelines that enforce branch coverage thresholds.
Changes
The fix treats branches as covered when they have
count === 0but contain ignored lines (ignoredLines > 0). This matches the behavior of c8 and ensures ignored code doesn't penalize branch coverage.Before:
After:
Test plan
test/parallel/test-runner-coverage.js0for ignored branchesFixes: #61586