Skip to content

src: expose help texts into node-config-schema.json #58680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pmarchini wants to merge 2 commits into from
Closed

src: expose help texts into node-config-schema.json #58680

pmarchini wants to merge 2 commits into from
+481 −237

Conversation

@pmarchini
Copy link
Member

@pmarchini pmarchini commented Jun 11, 2025

This is only a draft and needs a significant amount of refactoring before it can be considered "ready for review".
I'm opening it to gather some feedback!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2025

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 11, 2025
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch 3 times, most recently from 5a83586 to bf4b443 Compare June 28, 2025 11:42
@pmarchini pmarchini marked this pull request as ready for review June 29, 2025 19:32
@codecov
Copy link

codecov bot commented Jun 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 27.41935% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (720feff) to head (9afe68d).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 24.00% 38 Missing ⚠️
lib/internal/options.js 22.22% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58680      +/-   ##
==========================================
- Coverage   89.79%   89.77%   -0.02%     
==========================================
  Files         672      673       +1     
  Lines      203809   203874      +65     
  Branches    39187    39179       -8     
==========================================
+ Hits       183004   183024      +20     
- Misses      13123    13179      +56     
+ Partials     7682     7671      -11
Files with missing lines Coverage Δ
src/node_config_file.cc 81.95% <100.00%> (ø)
src/node_config_file.h 100.00% <ø> (ø)
src/node_options.h 97.89% <ø> (ø)
lib/internal/options.js 46.82% <22.22%> (-1.42%) ⬇️
src/node_options.cc 76.27% <24.00%> (-1.72%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from bf4b443 to eab8c05 Compare July 2, 2025 09:52
@pmarchini pmarchini requested a review from marco-ippolito July 2, 2025 09:55
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch 2 times, most recently from 2515e7f to eab8c05 Compare July 2, 2025 14:37
@pmarchini pmarchini requested review from anonrig and jasnell July 6, 2025 13:18
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67867/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67883/

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from 278089f to e2bda01 Compare August 17, 2025 10:36
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 17, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68677/

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from e2bda01 to 01764ec Compare August 24, 2025 10:49
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68847/

amilshahsahab
amilshahsahab reviewed Aug 24, 2025
View reviewed changes
Copy link

@amilshahsahab amilshahsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/node-config-schema.json

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68850/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68852/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68855/

@marco-ippolito marco-ippolito added the config Issues or PRs related to the config subsystem label Oct 6, 2025
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from 01764ec to 6833ccc Compare December 2, 2025 20:19
@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70374/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70384/

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70908/

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from 6833ccc to 9afe68d Compare January 30, 2026 15:11
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71130/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71131/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 30, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 30, 2026

Landed in e67848a...9d85244

nodejs-github-bot pushed a commit that referenced this pull request Jan 30, 2026
@pmarchini @nodejs-github-bot
src: expose help texts into node-config-schema.json
1e5e03d 
PR-URL: #58680
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 30, 2026
@pmarchini @nodejs-github-bot
test_runner: update node-config-schema
9d85244 
PR-URL: #58680
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@anonrig anonrig Awaiting requested review from anonrig

+1 more reviewer

@amilshahsahab amilshahsahab amilshahsahab left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. config Issues or PRs related to the config subsystem lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmarchini @nodejs-github-bot @marco-ippolito @amilshahsahab