feat(deps): use shrinkwrap instead of package lock#976
Merged
joyeecheung merged 1 commit intonodejs:mainfrom Sep 18, 2025
Merged
feat(deps): use shrinkwrap instead of package lock#976joyeecheung merged 1 commit intonodejs:mainfrom
joyeecheung merged 1 commit intonodejs:mainfrom
Conversation
As node-core-utils are CLI tools, it makes more sense to use shrinkwrap instead of package lock to allow users to install the CLI globally while pining transitive dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 39 39
Lines 4663 4663
=======================================
Hits 3719 3719
Misses 944 944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
targos
approved these changes
Sep 18, 2025
Member
|
I hope it's supported by dependabot. |
Member
Author
Member
|
Proven by #971 |
targos
added a commit
to targos/citgm
that referenced
this pull request
Sep 23, 2025
targos
added a commit
to nodejs/citgm
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As node-core-utils are CLI tools, it makes more sense to use shrinkwrap instead of package lock to allow users to install the CLI globally while pining transitive dependencies.
Fixes: #974