Skip to content

fix(ci): use main branch after merge#70

Merged
0xstepit merged 1 commit intomainfrom
stepit/fix-e2e-main
Nov 19, 2025
Merged

fix(ci): use main branch after merge#70
0xstepit merged 1 commit intomainfrom
stepit/fix-e2e-main

Conversation

@0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Nov 19, 2025

After merging a PR, the heighliner in the CI uses the tag as a git reference for the image to build. We want to use main or the e2e fail because use a wrong source for the binary.

Summary by CodeRabbit

  • Chores
    • Improved resilience of the e2e testing workflow by adding fallback logic for source code reference determination when standard reference is unavailable.

@0xstepit 0xstepit self-assigned this Nov 19, 2025
@0xstepit 0xstepit added bug Something isn't working test labels Nov 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A fallback mechanism is added to the e2e-tests workflow's git-ref computation. The variable now references github.head_ref || github.ref_name to handle scenarios where head_ref is unavailable, improving resilience without modifying surrounding workflow steps.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/e2e-tests.yaml
Added fallback to git-ref computation using github.head_ref || github.ref_name to resolve references when head_ref is unavailable

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration line modified with standard fallback pattern
  • No logic changes or side effects

Poem

🐰 A fallback so clever, so spry—
When head_ref fades, ref_name's nearby!
Resilient flows, no step left behind,
In workflows robust, such logic we find! 🌿

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch stepit/fix-e2e-main

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a93a1d9 and 5409315.

📒 Files selected for processing (1)
  • .github/workflows/e2e-tests.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xstepit 0xstepit changed the title ci: use main branch after merge fix(ci): use main branch after merge Nov 19, 2025
@0xstepit 0xstepit merged commit 97bef41 into main Nov 19, 2025
3 of 4 checks passed
@0xstepit 0xstepit deleted the stepit/fix-e2e-main branch November 19, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant