Skip to content

ci: run e2e when push to main#69

Merged
0xstepit merged 2 commits intomainfrom
stepit/ci-e2e
Nov 18, 2025
Merged

ci: run e2e when push to main#69
0xstepit merged 2 commits intomainfrom
stepit/ci-e2e

Conversation

@0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Nov 18, 2025

This PR updates the e2e ci to run when code is pushed to main. It should fix the e2e banner on the readme that displays a failing e2e even when everything pass correctly.

Summary by CodeRabbit

  • Chores

    • Enhanced end-to-end testing automation on the main branch to improve code quality assurance.
  • Documentation

    • Updated E2E testing status badge in README to reflect current branch information.

@0xstepit 0xstepit self-assigned this Nov 18, 2025
@0xstepit 0xstepit added bug Something isn't working documentation Improvements or additions to documentation labels Nov 18, 2025
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh nice, good improvement 🙌

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The E2E test workflow is updated to trigger on main branch pushes. The test result validation is refactored from a single-line conditional to a multi-line shell script that prints diagnostics and exits appropriately. The README badge URL is updated to reference the main branch.

Changes

Cohort / File(s) Change Summary
E2E Workflow Configuration
.github/workflows/e2e-tests.yaml
Added push trigger for main branch and replaced single-line conditional check with multi-line shell script for test result validation that prints output and exits with status 1 if result is not "success"
Documentation Badge
README.md
Updated E2E Tests badge URL to use branch=main parameter instead of jobName

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the shell script logic correctly evaluates the test result and exits with the appropriate status code
  • Confirm the branch=main parameter is the correct way to reference the workflow branch in the badge URL

Possibly related PRs

Suggested labels

test

Suggested reviewers

  • MalteHerrmann

Poem

🐰 Main branch now triggers with a push,
Shell scripts validate without rush,
Test results flow through logic true,
Badges gleam with main in view! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch stepit/ci-e2e

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a4f20d and 8091578.

📒 Files selected for processing (2)
  • .github/workflows/e2e-tests.yaml (2 hunks)
  • README.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xstepit 0xstepit enabled auto-merge (squash) November 18, 2025 12:34
@0xstepit 0xstepit disabled auto-merge November 18, 2025 12:34
@0xstepit 0xstepit merged commit a93a1d9 into main Nov 18, 2025
3 of 4 checks passed
@0xstepit 0xstepit deleted the stepit/ci-e2e branch November 18, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants