feat: add hyperlane contracts and custom application#45
feat: add hyperlane contracts and custom application#45MalteHerrmann wants to merge 35 commits intomainfrom
Conversation
…sted version of NobleDollar
…transient storage
…x hyperlane mocks to set up app router
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0xstepit
left a comment
0xstepit
left a comment
There was a problem hiding this comment.
Great design @MalteHerrmann ! Added the review for only the pending payload registration part as discussed remotely. Looking forward to see this live 🚀
| ) | ||
|
|
||
| // Keccak256Hash returns the keccak 256 hash of the payload contents. | ||
| // To guarantee uniqueness the sequence number is included. |
There was a problem hiding this comment.
this comment should be on the type
| } | ||
|
|
||
| // Validate checks that the pending payload contents are valid. | ||
| func (p *PendingPayload) Validate() error { |
There was a problem hiding this comment.
nit: this is a very edge case, but a payload that is valid at block let's say N, could be invalid at block N+1 when it is relayed.
0xstepit
changed the title
2 participants
No description provided.