Add equalizer presets to library to simplify implementation in Home Assistant#202
Open
Solmath wants to merge 4 commits intonoahhusby:mainfrom
Open
Add equalizer presets to library to simplify implementation in Home Assistant#202Solmath wants to merge 4 commits intonoahhusby:mainfrom
Solmath wants to merge 4 commits intonoahhusby:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out during review of home-assistant/core#162956, the presets should be part of the library.
This PR adds presets, as well as class methods to simplify implementation on HA side.
Note
I noticed that
will currently not actually enable the equalizer.
The reason is that the payload in
set_equalizer_params()only containsuser_eq_bandsbut notuser_eqlike inset_equalizer_mode().Should we change that, so the EQ will automatically be activated when selecting a preset?
To change presets in the StreamMagic App, you have to manually activate the EQ first.