Skip to content

Revert: use of connection pool for sqlite #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyvernIXTL merged 1 commit into from
Aug 11, 2025
Merged

Revert: use of connection pool for sqlite #171

WyvernIXTL merged 1 commit into from
Aug 11, 2025

Conversation

@WyvernIXTL
Copy link
Contributor

@WyvernIXTL WyvernIXTL commented Aug 11, 2025

Removed:

  • Removed r2d2 connection pool, due to being much slower (10%).

Checklist:

  • Do the unit tests in CAL run? Check at least those that you can run: cargo test -F software
  • Are changes in common propagated to all providers that are currently in use?
    • software
    • tpm/android
    • tpm/apple_secure_enclave
  • Did changes in the API occur, such that ./ts-types needs to be updated?
  • Do the dart bindings have to be re-generated?
  • Does the flutter plugin still compile?
  • Do the integration tests in flutter-app still run?
  • There are no build artifacts in the commit. (node_modules, lib, target and everything in .gitignore)

@WyvernIXTL
revert: use mutex instead of a connection pool for sqlite
281d9ef 
The reason is, that the very write and read heavy tests in crypto-layer-node
have shown a 10% improvement with Mutex.
@WyvernIXTL WyvernIXTL merged commit e3d79e1 into main Aug 11, 2025
4 checks passed
@WyvernIXTL WyvernIXTL deleted the revert/use-of-r2d2 branch August 11, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@WyvernIXTL