Skip to content

revise benchmark code for SRR 7 #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rick-Methot-NOAA wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −7
Open

revise benchmark code for SRR 7 #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions SS_recruit.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,26 @@ FUNCTION dvar_vector Equil_Spawn_Recr_Fxn(const dvar_vector& SRparm,
// SS_Label_44.1.7 3 parameter survival based
case 7: // survival
{
SRZ_0 = log(1.0 / (SSB_virgin_use / Recr_virgin_use));
srz_min = SRZ_0 * (1.0 - steepness);
B_equil = SSB_virgin_use * (1. - (log(1. / SSBpR_current) - SRZ_0) / pow((srz_min - SRZ_0), (1. / SRparm(3))));
SRZ_surv = mfexp((1. - pow((B_equil / SSB_virgin_use), SRparm(3))) * (srz_min - SRZ_0) + SRZ_0); // survival
R_equil = B_equil * SRZ_surv;
// z_frac is steepness
// incorrect code below was used prior to Jan 2026 revision
// SRZ_0 = log(1.0 / (SSB_virgin_use / Recr_virgin_use));
// srz_min = SRZ_0 * (1.0 - steepness);
// B_equil = SSB_virgin_use * (1. - (log(1. / SSBpR_current) - SRZ_0) / pow((srz_min - SRZ_0), (1. / SRparm(3))));
// SRZ_surv = mfexp((1. - pow((B_equil / SSB_virgin_use), SRparm(3))) * (srz_min - SRZ_0) + SRZ_0); // survival
// R_equil = B_equil * SRZ_surv;
dvariable SPR0 = SSB_virgin_use / Recr_virgin_use;
// warning << "SPR: " << SSBpR_current / SPR0 << " Old: " << B_equil << " " << R_equil;

// formula: pow( (1.0 - (log (SPR0 / SSBpR_current)) / (steepness * log (SPR0) )), (1. / SRparm(3)));
// use a join fxn to keep the quantity above 0.01, which is enough above 0.0 to assure no negative
dvariable temp = (1.0 - (log (SPR0 / SSBpR_current)) / (steepness * log (SPR0) ));
dvariable join1 = 1. / (1. + mfexp(100. * (temp - 0.01))); // steep logistic joiner
dvariable temp1 = join1 * 0.01 + (1. - join1) * (temp - 0.01);
B_equil = Recr_virgin_use * SPR0 *
pow( temp1, (1. / SRparm(3)));
R_equil = B_equil / SSBpR_current;
// warning << " log(SPR): " << log (SPR0 / SSBpR_current) << " denom " << steepness * log (SPR0) << " base: " <<
// (1.0 - (log (SPR0 / SSBpR_current)) / (steepness * log (SPR0) )) << " temp: " << temp << " " << join1 << " " << temp1 << " New: " << B_equil << " " << R_equil << endl;
break;
}

Expand Down
4 changes: 2 additions & 2 deletions SS_write_report.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4754,7 +4754,7 @@ FUNCTION void SPR_profile()
}
// do not recalculate here so force using values from benchmark
SS2out << "unfished values for SRR: SSB " << SSB0_4_SRR << " R " << R0_4_SRR << " SSBpR " << " SSBpR: " << SSB0_4_SRR / R0_4_SRR << endl;
SS2out << "SPRloop Iter Bycatch Fmult F_std SSBpR YpR_dead YpR_dead*Recr YpR_ret*Recr Revenue Cost Profit SSB Recruits SSB/Bzero Tot_Catch ";
SS2out << "SPRloop Iter Bycatch Fmult F_std SSBpR SPR YpR_dead YpR_dead*Recr YpR_ret*Recr Revenue Cost Profit SSB Recruits SSB/Bzero Tot_Catch ";
Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change. Isn't SSBpR the same as SPR? But in the values on line 4924 it looks like the SSBpR column would just contain SSB?

Copy link
Collaborator Author

@Rick-Methot-NOAA Rick-Methot-NOAA Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The confusion on SPR is that Spawner Potential Ratio and Spawning Stock Biomass per Recruit are both abbreviated to SPR, but the former is the ratio of fished SSBpR to unfished SSBpR. So, better usage is SSBpR and %SPR. This is part of the change that happened with the big revamp of the spawner-recruitment calculations last year.

The change is only in the header. The columns of output already included SSBpR and SPR, which I should change to %SPR to align with NS1 technical guidance

Also, SS3 gets SSBpR by getting the SSB for a recruitment set equal to 1.0

for (f = 1; f <= Nfleet; f++)
{
if (fleet_type(f) <= 2)
Expand Down Expand Up @@ -4921,7 +4921,7 @@ FUNCTION void SPR_profile()
if (SPRloop1 == 0)
Fcrash = Fmult2;
}
SS2out << SPRloop1 << " " << SPRloop << " " << with_BYC << " " << Fmult2 << " " << equ_F_std << " " << SSB_equil / (SSB0_4_SRR / R0_4_SRR) << " " << YPR_dead << " "
SS2out << SPRloop1 << " " << SPRloop << " " << with_BYC << " " << Fmult2 << " " << equ_F_std << " " << SSB_equil << " " << SSB_equil / (SSB0_4_SRR / R0_4_SRR) << " " << YPR_dead << " "
<< YPR_dead * Btgt_prof_rec << " " << YPR_ret * Btgt_prof_rec << " " << (PricePerF * YPR_val_vec) * Btgt_prof_rec
<< " " << Cost << " " << (PricePerF * YPR_val_vec) * Btgt_prof_rec - Cost << " " << Btgt_prof << " " << Btgt_prof_rec << " " << Btgt_prof / SSB0_4_SRR
<< " " << value(sum(equ_catch_fleet(2)) * Btgt_prof_rec);
Expand Down
Loading