-
Notifications
You must be signed in to change notification settings - Fork 3
Deviation parameters #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deviation parameters #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances documentation for parameter deviations in SS3, addressing issue #99 by adding comprehensive explanations and implementation guidance based on a Parameter Deviations document.
Key changes include:
- Added detailed mathematical formulation and implementation notes for parameter deviations
- Enhanced existing parameter deviation descriptions with hyperlinks and clarifications
- Documented version-specific issues and best practices for parameter deviation estimation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tv_parameter_description.tex | Enhanced parameter deviation descriptions with hyperlinks, clarified formulations, and corrected terminology |
| 9control.tex | Added comprehensive Parameter Deviations subsection with mathematical formulation, implementation notes, and best practices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Here are the artifacts from your PR: |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Here are the artifacts from your PR: |
|
@Rick-Methot-NOAA could you give this a review? |
|
It will take me awhile to get my head back into this topic, but I agree it needs to be done. I will get to it after working on the Gompertz growth issue. |
See issue #99 and #219.
Used the Parameter Deviations doc @Rick-Methot-NOAA created to try to enhance documentation. Please review and let me know if that all looks right and if there is anything that should be added.