Conversation
Collaborator
|
I've used URL search parameters to modify location in hakunapi-html-npm-openlayers f.ex. hakunapi-html-npm-openlayers has some other packaging and distribution build tree shaking issues though. |
Collaborator
Author
|
That's a lot better, I'll change all of these to use that pattern. |
Collaborator
Author
|
This seems to work with everything I throw at it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is that window.location.href already contains the window.location.search causing duplicated search part
Simplify JSON link construction in all files to just append
(?|&)f=jsonto window.location.href based on search being empty (then ?) or not (then &). This should additionally fix JSON links when using any other query parameters (?filter=or?api-key=<key>for example).Not ideal still, if current search already contains value for query param
fthen this won't work, but that basically requires the user to manually enter ?f=html, which shouldn't really happen.Should fix #160