Revert encode to padded base32/base64 output#92
Merged
Conversation
Most WARC implementations write padded base32/base64 digest values. The WARC spec issue #48 acknowledges this as existing practice and proposes fixing the grammar rather than changing implementations. Revert encode() to use standard padded encodings (base32.StdEncoding, base64.StdEncoding). The read path continues to accept both padded and unpadded digests for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most WARC implementations write padded base32/base64 digest values. The WARC spec issue #48 acknowledges this as existing practice and proposes fixing the grammar rather than changing implementations.
Revert encode() to use standard padded encodings (base32.StdEncoding, base64.StdEncoding). The read path continues to accept both padded and unpadded digests for backward compatibility.