🎨 Palette: Improve password input accessibility#89
Conversation
- Add `showPassword` and `hidePassword` translation keys to `web/src/locales/en.ts`. - Update `Input` component in `web/src/components/ui/input.tsx` to use these keys for `aria-label`. - Add `aria-pressed` state to the password toggle button. - Initialize `useTranslation` hook within `Input` component (import was already present). Co-authored-by: nkissick-del <236767245+nkissick-del@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
💡 What: Added accessibility attributes (
aria-labelandaria-pressed) to the password visibility toggle button in theInputcomponent.🎯 Why: Screen reader users could not determine the purpose or state of the password toggle button.
♿ Accessibility:
- Added
aria-labelswitching between "Show password" and "Hide password".- Added
aria-pressedto indicate current state.PR created automatically by Jules for task 9249884240414342064 started by @nkissick-del
Summary by cubic
Improve password input accessibility by adding screen reader labels and state to the visibility toggle in the Input component. The button now uses a dynamic aria-label (“Show password”/“Hide password”) and aria-pressed, with new i18n keys added to the English locale.
Written for commit 3ca6c3a. Summary will update on new commits.