Skip to content

🎨 Palette: Add accessibility to password input toggle#85

Open
nkissick-del wants to merge 1 commit intomainfrom
palette-password-toggle-accessibility-7214865278239618642
Open

🎨 Palette: Add accessibility to password input toggle#85
nkissick-del wants to merge 1 commit intomainfrom
palette-password-toggle-accessibility-7214865278239618642

Conversation

@nkissick-del
Copy link
Copy Markdown
Owner

@nkissick-del nkissick-del commented Feb 4, 2026

💡 What: Added aria-label to the password visibility toggle button in the Input component and cleaned up the login page.
🎯 Why: The password toggle button was accessible only via mouse clicks and lacked screen reader support (missing accessible name). The login page also had dead code attempting to implement this feature manually.
📸 Visuals: No visual changes, but the button now has an accessible name ("Show password" / "Hide password").
Accessibility: Added dynamic aria-label to the toggle button to announce state changes to screen readers.


PR created automatically by Jules for task 7214865278239618642 started by @nkissick-del


Summary by cubic

Adds an accessible label to the password visibility toggle in the Input component to support screen readers. Cleans up the login page by removing a redundant manual toggle.

  • Bug Fixes

    • Add dynamic aria-label to the toggle button so screen readers announce “Show password” / “Hide password”.
  • Refactors

    • Move “Show/Hide password” strings to the common namespace for reuse.
    • Remove unused password toggle code from the login page.

Written for commit af415b4. Summary will update on new commits.

- Add `aria-label` to the password visibility toggle in `Input` component.
- Move "Show/Hide password" translation keys to `common` namespace for reuse.
- Remove redundant manual password toggle implementation in login page.
- Ensure generic `Input` component uses generic translation keys.

Co-authored-by: nkissick-del <236767245+nkissick-del@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant