🎨 Palette: Add accessibility to password input toggle#85
🎨 Palette: Add accessibility to password input toggle#85nkissick-del wants to merge 1 commit intomainfrom
Conversation
- Add `aria-label` to the password visibility toggle in `Input` component. - Move "Show/Hide password" translation keys to `common` namespace for reuse. - Remove redundant manual password toggle implementation in login page. - Ensure generic `Input` component uses generic translation keys. Co-authored-by: nkissick-del <236767245+nkissick-del@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
aria-labelto the password visibility toggle button in theInputcomponent and cleaned up the login page.🎯 Why: The password toggle button was accessible only via mouse clicks and lacked screen reader support (missing accessible name). The login page also had dead code attempting to implement this feature manually.
📸 Visuals: No visual changes, but the button now has an accessible name ("Show password" / "Hide password").
♿ Accessibility: Added dynamic
aria-labelto the toggle button to announce state changes to screen readers.PR created automatically by Jules for task 7214865278239618642 started by @nkissick-del
Summary by cubic
Adds an accessible label to the password visibility toggle in the Input component to support screen readers. Cleans up the login page by removing a redundant manual toggle.
Bug Fixes
Refactors
Written for commit af415b4. Summary will update on new commits.