Fixing the issue of connections forming loops between nodes#70
Open
hxdnshx wants to merge 1 commit intonkchocoai:masterfrom
Open
Fixing the issue of connections forming loops between nodes#70hxdnshx wants to merge 1 commit intonkchocoai:masterfrom
hxdnshx wants to merge 1 commit intonkchocoai:masterfrom
Conversation
hxdnshx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, I've been attempting to use SaveImageWithMetaData in some very complex workflows. Honestly, it's excellent for populating metadata.
However, during my recent run, I noticed the waiting time was extremely long. After examining it with a debugger, I found it frequently pausing in the
trace.py trace()function.Specifically, I discovered that the total size of Q reached over 100,000, while my workflow had fewer than 2,000 nodes total. Therefore, I initially assessed that the traverse operation wasn't performing deduplication, causing some nodes to be calculated multiple times. In this MR, I attempted to implement deduplication to prevent nodes from being recalculated.
After the modification, the overall runtime decreased from 280 seconds to infinity, to under 1 minute. And the output metadata appears to be correct.