Conversation
jlconlin
left a comment
jlconlin
left a comment
There was a problem hiding this comment.
Nice Pull Request. Thanks for your contribution. Just a few minor things to take care before this is finalized.
njoy2016/README.md
Outdated
|
|
||
| - `23`: | ||
| This is the version NJOY2016.23 associated with the git tag `2016.23`. | ||
| Within these subfolders you will find Dockerfiles that define the builds for Docker images |
There was a problem hiding this comment.
There is no need to put this on separate lines. It makes it difficult to modify—and stay consistent—in the future.
There was a problem hiding this comment.
Thanks - I'm happy to make changes but do you mean remove the bullets or the newlines in the text?
There was a problem hiding this comment.
What I mean is lines 3--7. They should all be on line line.
There was a problem hiding this comment.
Thanks - I've made the change.
| and, with a operating version of Docker on your machine, download them using: | ||
|
|
||
| ``` | ||
| docker pull njoy21/njoy2016:44 |
There was a problem hiding this comment.
I'll need to actually put this on Docker Hub when this is done.
There was a problem hiding this comment.
Yes, but there is also the option of automated builds with docker hub.
See: https://docs.docker.com/docker-hub/builds/
These can be setup for github and bitbucket and cause automatic builds whenever there is a push to certain branches of the repo. In this case, you could trigger the build(s) automatically.
2 participants
Hi @jlconlin,
As discussed, here is a version 44 Dockerfile. I've tested that it builds and added a few lines to the readme.
Best,
Michael