-
Notifications
You must be signed in to change notification settings - Fork 1
macOS nix-static builder overhaul #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Once this change hits |
This comment was marked as outdated.
This comment was marked as outdated.
This allows us to leverage a static binary build that actually works, including on Darwin, and comes with the added benefit of a much simplified Nix version model -- whatever's written on top of the flake.nix, that's the version you'll be shipping. Only time will tell if this approach is more robust, and ideally the patch set will be cleaned up and upstreamed.
Member
Author
|
New approach based on upstream Nix build system yields very promising results: however the Getting close! |
5c9b335 to
4f7d96c
Compare
4f7d96c to
10928dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: aarch64-darwin
Specific to Darwin on AArch64
platform: x86_64-darwin
Specific to Darwin on x86_64
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant for testing and adapting NixOS/nixpkgs#346043 to Nixie's
static-binspackage, in an effort to leverage as much code from upstream as possible and make updates easier.Since 3f8326b, this PR also overhauls the static Nix build system to directly use NixOS/nix rather than Nixpkgs, with possible patches per-platform.