docs: mention homemanager module import#100
docs: mention homemanager module import#100gabyx wants to merge 2 commits intonix-community:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the README to document an additional Home Manager usage pattern by importing the flake’s Home Manager module from within a Home Manager module.
Changes:
- Add a Home Manager module example that imports
inputs.vscode-server.homeModules.default. - Document enabling
services.vscode-server.enablein that module-based setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| or with the module import inside a home-manager module: | ||
|
|
There was a problem hiding this comment.
This sentence starts mid-sentence with a lowercase "or" and uses inconsistent naming vs the section header ("Home Manager"). Consider changing to a full sentence starting with "Or" and using "Home Manager" for consistency/readability.
| { inputs, osConfig, ... }: | ||
| { | ||
| imports = [ | ||
| inputs.vscode-server.homeModules.default |
There was a problem hiding this comment.
This example assumes the module receives an inputs argument, but Home Manager modules won't have inputs unless the user passes it (e.g., via extraSpecialArgs/specialArgs in their home-manager configuration). As written, inputs will be undefined for many setups; please mention the required extraSpecialArgs = { inherit inputs; }; (or adjust the snippet to not require inputs).
| { inputs, osConfig, ... }: | |
| { | |
| imports = [ | |
| inputs.vscode-server.homeModules.default | |
| { config, ... }: | |
| let | |
| vscode-server = builtins.getFlake "github:nix-community/nixos-vscode-server"; | |
| in { | |
| imports = [ | |
| vscode-server.homeModules.default |
| or with the module import inside a home-manager module: | ||
|
|
||
| ```nix | ||
| { inputs, osConfig, ... }: |
There was a problem hiding this comment.
osConfig is included in the argument set but not used in this snippet. Dropping it (or showing a use for it) would avoid confusion about when/why osConfig is needed.
| { inputs, osConfig, ... }: | |
| { inputs, ... }: |
Ten0
left a comment
There was a problem hiding this comment.
Looks like copilot's comments are relevant, otherwise LGTM.
No description provided.