Skip to content

docs: mention homemanager module import#100

Open
gabyx wants to merge 2 commits intonix-community:masterfrom
gabyx:patch-1
Open

docs: mention homemanager module import#100
gabyx wants to merge 2 commits intonix-community:masterfrom
gabyx:patch-1

Conversation

@gabyx
Copy link
Copy Markdown

@gabyx gabyx commented Feb 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 25, 2026 09:55
Comment thread README.md Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the README to document an additional Home Manager usage pattern by importing the flake’s Home Manager module from within a Home Manager module.

Changes:

  • Add a Home Manager module example that imports inputs.vscode-server.homeModules.default.
  • Document enabling services.vscode-server.enable in that module-based setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +94 to +95
or with the module import inside a home-manager module:

Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence starts mid-sentence with a lowercase "or" and uses inconsistent naming vs the section header ("Home Manager"). Consider changing to a full sentence starting with "Or" and using "Home Manager" for consistency/readability.

Copilot uses AI. Check for mistakes.
Comment thread README.md
Comment on lines +97 to +100
{ inputs, osConfig, ... }:
{
imports = [
inputs.vscode-server.homeModules.default
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example assumes the module receives an inputs argument, but Home Manager modules won't have inputs unless the user passes it (e.g., via extraSpecialArgs/specialArgs in their home-manager configuration). As written, inputs will be undefined for many setups; please mention the required extraSpecialArgs = { inherit inputs; }; (or adjust the snippet to not require inputs).

Suggested change
{ inputs, osConfig, ... }:
{
imports = [
inputs.vscode-server.homeModules.default
{ config, ... }:
let
vscode-server = builtins.getFlake "github:nix-community/nixos-vscode-server";
in {
imports = [
vscode-server.homeModules.default

Copilot uses AI. Check for mistakes.
Comment thread README.md
or with the module import inside a home-manager module:

```nix
{ inputs, osConfig, ... }:
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osConfig is included in the argument set but not used in this snippet. Dropping it (or showing a use for it) would avoid confusion about when/why osConfig is needed.

Suggested change
{ inputs, osConfig, ... }:
{ inputs, ... }:

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like copilot's comments are relevant, otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants