fix(ssh): perform root command elevation test once before password input#204
Open
water-sucks wants to merge 1 commit intonix-community:mainfrom
Open
fix(ssh): perform root command elevation test once before password input#204water-sucks wants to merge 1 commit intonix-community:mainfrom
water-sucks wants to merge 1 commit intonix-community:mainfrom
Conversation
water-sucks
force-pushed
the
allow-passwordless-remote-cmd
branch
from
76de293 to
37104fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user was configured to have passwordless
sudo/doaselevation, attempting to activate with that user innixos apply --target-hostwas broken since it would always ask for a password whenEnsureRemoteRemotePasswordwas called.To avoid this scenario and allow for non-interactive deployments, this PR performs a test of the elevation command once to see if this access is already available, even with a nonexistent password.