This repository was archived by the owner on Oct 28, 2025. It is now read-only.
Introduce a new overrideInputs on {default,shell}Nix#4
Open
ElvishJerricco wants to merge 1 commit intonix-community:masterfrom
Open
Introduce a new overrideInputs on {default,shell}Nix#4ElvishJerricco wants to merge 1 commit intonix-community:masterfrom
overrideInputs on {default,shell}Nix#4ElvishJerricco wants to merge 1 commit intonix-community:masterfrom
Conversation
This allows the user of this non-flake to have similar functionality
to `follows`.
Example (default.nix):
nix-repl> (import ./.).default
«derivation /nix/store/axgvq22kyb8ymchzq1mjayms4jdl6ni6-ledc-0.1.0.drv»
nix-repl> ((import ./.).overrideInputs { nixpkgs = <nixpkgs>; }).default
«derivation /nix/store/r8zw693hpg91yx6f57hyx1gk4zdiq2lm-ledc-0.1.0.drv»
Member
|
I tested this and it seems to work fine |
|
This breaks on the dwarffs flake (https://github.com/edolstra/dwarffs/tree/9861d09c7a22f86d44e41d5ac049e7b4a8d1998d) with an "expected a string but found a list" error, presumably due to the structure of the nixpkgs follow. |
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
DavHau
reviewed
Feb 24, 2024
Comment on lines
+143
to
+147
| rootOverrides = | ||
| mapAttrs' | ||
| (input: lockKey: nameValuePair lockKey (impureOverrides.${input} or null)) | ||
| lockFile.nodes.${lockFile.root}.inputs; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| rootOverrides = | |
| mapAttrs' | |
| (input: lockKey: nameValuePair lockKey (impureOverrides.${input} or null)) | |
| lockFile.nodes.${lockFile.root}.inputs; | |
| rootOverrides = | |
| mapAttrs' | |
| (input: lockKey': let | |
| lockKey = | |
| if builtins.isList lockKey' | |
| then builtins.concatStringsSep "/" lockKey' | |
| else lockKey'; | |
| in | |
| nameValuePair lockKey (impureOverrides.${input} or null)) | |
| lockFile.nodes.${lockFile.root}.inputs; |
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
DavHau
added a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
mergify bot
pushed a commit
to nix-community/dream2nix
that referenced
this pull request
Feb 24, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
Member
|
For some reason this PR skipped my attention.. what is the status of it? |
Author
|
@zimbatm If I understand correctly, @DavHau's suggestion will fix the issue mentioned @alois31, which is that doing something like |
chaoflow
pushed a commit
to chaoflow/dream2nix
that referenced
this pull request
Nov 16, 2024
- downgrade mitmproxy to avoid breakage - add test for pip lock script - fix bug in flake compat implementation (nix-community/flake-compat#4 (comment)) - small fix in docs for lock and eval-cache - fix lock refresh script: don't swallow errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting NixOS#49 with some edits to avoid re-indentation and to fix a null reference bug.
This allows the user of this non-flake to have similar functionality to
follows.Example (default.nix):