Accommodate OS-9/68000 releases that accept either the old explicit #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlindner
reviewed
Jan 3, 2026
Member
tlindner
left a comment
tlindner
left a comment
There was a problem hiding this comment.
This looks great! I used this to build NitrOS-9 and successfully built Level 2 and it booted in Mame. If you don't get to the sprintf thing in a few day, I'll just commit it as is.
length and LSN of the bootfile's first segment or the zero length and LSN of the bootfile's file descriptor. Set both LSN possibilities in a semantically meaningful way rather than counting on an accident of how RBF allocates the file descriiptor sector and the first segment in a contiguous hunk. Clarify the condition that os9 gen uses as a contiguity test and why in this context it gives the desired result. Also, use snprintf() with checks for overrun when generating path names for -b and -t, and declare size to be u_int to avoid complaints about &size to _os9_read().
jejones3141
force-pushed
the
os9gen_extended_dd_bt
branch
from
bbd15b2 to
1f19905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
length and LSN of the bootfile's first segment or the zero length and LSN of the bootfile's file descriptor.
Set both LSN possibilities in a semantically meaningful way rather than counting on an accident of how RBF allocates the file descriiptor sector and the first segment in a contiguous hunk.
Clarify the condition that os9 gen uses as a contiguity test and why in this context it gives the desired result.