Add support for adding a custom function to marshal/unmarshall variables#258
Draft
trojanc wants to merge 1 commit intonitram509:mainfrom
Draft
Add support for adding a custom function to marshal/unmarshall variables#258trojanc wants to merge 1 commit intonitram509:mainfrom
trojanc wants to merge 1 commit intonitram509:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 63.44% 62.98% -0.47%
==========================================
Files 28 28
Lines 1896 1991 +95
==========================================
+ Hits 1203 1254 +51
- Misses 647 680 +33
- Partials 46 57 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
589d327 to
bb9f6bd
Compare
bb9f6bd to
954ba52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Abstract
please describe in 1-3 sentences,
VarHolder, the original types gets lost. This is a problem when you have complex structures in your variables (e.g structs from a REST Server/Client)MarshalandUnmarshalfunctions that gives you an opportunity to change the variable in themapjust before it is Marshalled, and right after is is Unmarshalled and put back into the map.panicsfromMarshalandUnmarshalit now returns anerrorDescription/Comments
lib-bmpn-engine. It uses reflection and exports the types of items in the VarHolder allowing it to be reconstructed when unmarshalled back from JSONChecklist
Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below
Tests
Code examples
Documentation