makes parity with native filter function#66
Open
kalpeshsingh wants to merge 1 commit intonitish24p:masterfrom
Open
makes parity with native filter function#66kalpeshsingh wants to merge 1 commit intonitish24p:masterfrom
kalpeshsingh wants to merge 1 commit intonitish24p:masterfrom
Conversation
The `newFilter` method allows undefined to be part of the filtered array but the native implementation removes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the issue?
The
newFiltermethod allows undefined values to be part of the filtered array but the native implementation removes that.How to replicate it?
Add
numbers[7] = 9and change condition to filter odd numbers and you will find out that it doesn't filter empty/undefined values in the array.numbers array would be -
What is the reason?
When we call
callback.call(context, this[index], index, this)for undefined value then it producestrueand it pushes the value toresultarray.How to prevent it?
We need to put a guard condition to only allow values that are actually part of the array and not produced artificially. The proposed condition makes sure that it matches with native
.filteroutput.