Skip to content

Confirm password on register. #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cryptogun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Confirm password on register. #209

cryptogun wants to merge 1 commit into from

Conversation

@cryptogun
Copy link
Contributor

@cryptogun cryptogun commented Nov 4, 2017

Cause everybody does so. And Django does so.

  1. Use Django builtin UserCreationForm (which auto confirm for us).
  2. Code of user creation based on Django source code.

@cryptogun
Confirm password on register.
4038f53 
1. Use Django builtin UserCreationForm (which auto confirm for us).
2. Code of user creation based on Django source code.
@nitely
Copy link
Owner

nitely commented Nov 4, 2017

uhm, I want the email confirmation and the case_insensitive emails. The reason there is no password confirmation is coz password can be reset anyway. Confirming the email is way more important.

@cryptogun
Copy link
Contributor Author

cryptogun commented Nov 4, 2017

Okey, both make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cryptogun @nitely