fix(ui): read participant_id and session_id from args instead of hardcoded values#18
Open
laurapiro17 wants to merge 2 commits intonipoppy:mainfrom
Open
fix(ui): read participant_id and session_id from args instead of hardcoded values#18laurapiro17 wants to merge 2 commits intonipoppy:mainfrom
laurapiro17 wants to merge 2 commits intonipoppy:mainfrom
Conversation
…coded values participant_id was hardcoded to 'sub-ED01' and session_id to 'ses-01', ignoring the --participant_list and --session_list arguments entirely. also removes duplicate 'import streamlit as st' on line 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
participant_id was hardcoded to 'sub-ED01' and session_id to 'ses-01', so passing --participant_list or --session_list had no effect on which participant was displayed. this reads participant_id from participants_df using the current page index, and session_id from the session_list arg. also removes a duplicate 'import streamlit as st' on line 11.