fix(pipelines): correct svg_montage_path key typo in qsiprep config#16
Open
laurapiro17 wants to merge 1 commit intonipoppy:mainfrom
Open
fix(pipelines): correct svg_montage_path key typo in qsiprep config#16laurapiro17 wants to merge 1 commit intonipoppy:mainfrom
laurapiro17 wants to merge 1 commit intonipoppy:mainfrom
Conversation
'svg_montage_,path' had a stray comma in the key name for t1_2_mni_qc, sdc_wf_qc and coreg_wf_qc — causing SVG montages to silently not load for those QC tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the key
"svg_montage_,path"(with a stray comma) appears in three QC tasks inqsiprep_qc.json:t1_2_mni_qcsdc_wf_qccoreg_wf_qcbecause the key doesn't match the
QCTaskpydantic model field name, the SVG montage paths are silently ignored and those panels show "SVG montage not found" even when the files exist. renamed all three to"svg_montage_path".anat_wf_qcwas already correct.