Fixed bug in correspondences of LS point to plane ICP and made norm(p…#6
Open
stachnis wants to merge 1 commit intoniosus:masterfrom
Open
Fixed bug in correspondences of LS point to plane ICP and made norm(p…#6stachnis wants to merge 1 commit intoniosus:masterfrom
stachnis wants to merge 1 commit intoniosus:masterfrom
Conversation
…-q) plots being generated identical and look consistent over all ICP variants
Owner
|
Thanks @stachnis! I only now got to look at this and understand the change and you are totally right! The order of normals was, of course, totally messed up! I merged the first change from a different PR (#7) as that generated a better diff. This PR adds 47 thousand lines! The diff might be so huge either because you did not re-run the notebook with a kernel restart before submitting or because it was done from a mac 🤷♂️ Could you tell me in some way what was the second change you suggested in this MR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixed bug in correspondences of LS point to plane ICP (in function: prepare_system_normals)
Changes to:
for (i, j) in correspondences:
p_point = P[:, [i]]
q_point = Q[:, [j]]
nn = normals[j]
e = nn.dot(error(x, p_point, q_point))
J = nn.dot(jacobian(x, p_point))
Compute and plot norm(P-Q) error consistently for all ICP variants for better comparison