Skip to content

Conversation

@nini22P
Copy link
Owner

@nini22P nini22P commented Nov 1, 2025

Changelog

  • Migrate to MPL-2.0 license
  • Add more media type support
  • Fix key open subtitle and audio track issue
  • Fix popup layer cannot be closed with Esc key issue

更新日志

  • 迁移到 MPL-2.0 许可证
  • 添加更多媒体类型支持
  • 修复按键打开字幕和音频轨道的问题
  • 修复弹出层无法使用 Esc 键关闭的问题

@gemini-code-assist
Copy link

Summary of Changes

Hello @nini22P, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces version 1.5.2, focusing on a significant license change, broader media compatibility, and critical bug fixes. The project has transitioned from AGPLv3 to the more permissive MPL-2.0 license. Additionally, the update expands the range of supported audio and video file formats, and addresses issues related to subtitle/audio track selection and the ability to close popups using the Escape key.

Highlights

  • License Migration: The project's licensing has been migrated from AGPLv3 to the Mozilla Public License Version 2.0 (MPL-2.0), with all relevant license files and documentation updated accordingly.
  • Expanded Media Type Support: Significantly expanded the range of supported audio and video media types, enhancing the player's compatibility with a broader array of file formats.
  • Subtitle and Audio Track Fix: Resolved an issue where the key binding for opening the subtitle and audio track selection popup was not functioning correctly, ensuring proper context provision.
  • Escape Key Popup Closure: Implemented a fix that allows popup layers to be closed using the Esc key, improving user experience and navigation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

此 PR 为 v1.5.2 版本更新。主要包括:迁移到 MPL-2.0 许可证、添加更多媒体类型支持,以及修复了两个 Bug。整体代码变更清晰,与更新日志描述一致。我发现了一个潜在的内存泄漏问题和一个 pubspec.yaml 中的小错误,请查看我的具体评论。

@nini22P nini22P merged commit 30f5418 into main Nov 1, 2025
6 checks passed
@nini22P nini22P linked an issue Nov 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

使用快捷键打开字幕和音轨时会出错

2 participants