internal: nkError semIdentVis/IdentWithPragma#767
Draft
saem wants to merge 5 commits intonim-works:develfrom
Draft
internal: nkError semIdentVis/IdentWithPragma#767saem wants to merge 5 commits intonim-works:develfrom
nkError semIdentVis/IdentWithPragma#767saem wants to merge 5 commits intonim-works:develfrom
Conversation
going to refactor: - generate one `nkError` node - contains a set of issue markers - can generate more than one diagnostic message
Still not happy with the API and a few things are vague, to think about: - `semIdentVis` muddles AST sem, and evaling a symbol constructor - symbol construction wants to succeed regardless (for nimsuggest/check) - AST needs to capture the errors (for `sempass2` output) - how to keep sem idempotent with pragma/export AST sticking around? - maybe `semAfterMacroCall` can wrap output in `nkError`? - the getSym/Recover proc feel off Teasing this apart feels unnecessarily difficult, but perhaps it'll have large knockon effects to various parts of sem. Especially when it comes to clarifying semanticizing AST, symbolic, and type parts of sem.
saem
added
refactor
will clean-up later, but one takeaway is symbol producing `newSymG` that places errors in the `.ast` field. That seems potentially cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semIdentVisand friends to producenkErrorinstead or uselocalReportDetails
Notes for Reviewers
TODO/Thinking List
semIdentVismuddles AST sem, and evaling a symbol constructorsempass2output)semAfterMacroCallcan wrap output innkError?