Skip to content

initial cut of the change#691

Draft
saem wants to merge 6 commits intonim-works:develfrom
saem:saem-ast-nksymchoices-store-symbol-lists
Draft

initial cut of the change#691
saem wants to merge 6 commits intonim-works:develfrom
saem:saem-ast-nksymchoices-store-symbol-lists

Conversation

@saem
Copy link
Copy Markdown
Collaborator

@saem saem commented May 7, 2023

pretty sure there is a bug in semtempl, maybe semgnrc

Summary

  • what changed and how?
  • why are we changing it?

Details

  • info that couldn't fit into the summary
  • relevant details; tricky parts
  • anything else

Fixes full_issue_url

Notes for Reviewers

  • first cut of the change
  • need to ferret out the bugs
  • finish updating macros API
  • add in any quick wins

@saem
initial cut of the change
546f6de 
pretty sure there is a bug in `semtempl`, maybe `semgnrc`
@saem saem added refactor Implementation refactor compiler General compiler tag simplification Removal of the old, unused, unnecessary or un/under-specified language features. labels May 7, 2023
zerbina
zerbina reviewed May 7, 2023
View reviewed changes
Comment thread compiler/sem/semfields.nim Outdated
saem and others added 5 commits May 7, 2023 10:21
@saem @zerbina
instFieldLoopBody: preserve sym choice
7ba3954 
Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
@saem
made significant progress
a62d22a 
issue right now is lambdalifting is seeing choices, which seems off.
@saem
more progress
06a61ed 
- `lambdalifting.detectCapturedVars` ignores `nkNimNodeLit`
- added some debug code for `detectCapturedVar` errors
- need to debug why `cgen` is seeing a `nkSymChoice`
@saem
more debugging code
bb21369
@saem
fix semtypinst.prepareNode
e217689
@saem saem marked this pull request as draft May 9, 2023 18:53
@saem saem mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerbina zerbina zerbina left review comments

Assignees

No one assigned

Labels

compiler General compiler tag refactor Implementation refactor simplification Removal of the old, unused, unnecessary or un/under-specified language features.

Projects

None yet

Milestone

Semantic analysis phase rework

Development

Successfully merging this pull request may close these issues.

3 participants

@saem @zerbina @haxscramper