Skip to content

fixed error "Uncaught TypeError: Failed to execute 'createObjectURL' … … …on 'URL': No function was found that matched the signature provided." by replacing src with srcObject and assigning it stream object #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbialobos wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixed error "Uncaught TypeError: Failed to execute 'createObjectURL' … … …on 'URL': No function was found that matched the signature provided." by replacing src with srcObject and assigning it stream object #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a9f550
fixed error "Uncaught TypeError: Failed to execute 'createObjectURL' …
Dec 22, 2018
16ed0ea
Merge pull request #1 from iridiumsoft/iridiumsoft-patch-srcObject
Dec 22, 2018
c6dbf42
- Remove last call to URL.createObjectURL
Jan 8, 2019
b3dbd66
Remove example folder because it is empty
Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dist/symple.player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@

// If there is an active stream then play it now.
if (this.stream) {
this.video.src = URL.createObjectURL(this.stream)
this.video.srcObject = this.stream
this.video.play()
this.setState('playing')
return
Expand All @@ -365,7 +365,7 @@
navigator.getUserMedia(this.options.userMediaConstraints,
function (localStream) { // success
// Play the local video stream and create the SDP offer.
self.video.src = URL.createObjectURL(localStream)
self.video.srcObject = localStream
self.pc.addStream(localStream)
self.pc.createOffer(
function (desc) { // success
Expand Down Expand Up @@ -480,13 +480,13 @@
}
}
this.pc.onaddstream = function (event) {
S.log('symple:webrtc: remote stream added', URL.createObjectURL(event.stream))
S.log('symple:webrtc: remote stream added', event)

// Set the state to playing once candidates have completed gathering.
// This is the best we can do until ICE onstatechange is implemented.
self.setState('playing')

self.video.src = URL.createObjectURL(event.stream)
self.video.srcObject = event.stream
self.video.play()

// Store the active stream
Expand Down
2 changes: 1 addition & 1 deletion dist/symple.player.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion example
Open in desktop
Submodule example deleted from 5c4ed1
8 changes: 4 additions & 4 deletions src/symple.player.webrtc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@

// If there is an active stream then play it now.
if (this.stream) {
this.video.src = URL.createObjectURL(this.stream)
this.video.srcObject = this.stream
this.video.play()
this.setState('playing')
return
Expand All @@ -124,7 +124,7 @@
navigator.getUserMedia(this.options.userMediaConstraints,
function (localStream) { // success
// Play the local video stream and create the SDP offer.
self.video.src = URL.createObjectURL(localStream)
self.video.srcObject = localStream
self.pc.addStream(localStream)
self.pc.createOffer(
function (desc) { // success
Expand Down Expand Up @@ -239,13 +239,13 @@
}
}
this.pc.onaddstream = function (event) {
S.log('symple:webrtc: remote stream added', URL.createObjectURL(event.stream))
S.log('symple:webrtc: remote stream added', event)

// Set the state to playing once candidates have completed gathering.
// This is the best we can do until ICE onstatechange is implemented.
self.setState('playing')

self.video.src = URL.createObjectURL(event.stream)
self.video.srcObject = event.stream
self.video.play()

// Store the active stream
Expand Down