Remove unused variable, install uv instead of suggest#203
Merged
nikopueringer merged 1 commit intonikopueringer:mainfrom Mar 23, 2026
Merged
Remove unused variable, install uv instead of suggest#203nikopueringer merged 1 commit intonikopueringer:mainfrom
nikopueringer merged 1 commit intonikopueringer:mainfrom
Conversation
Removed unused variable usage. Install UV instead of error message. Let UV throws an error if UV cannot be installed on target machine. Since the user wants to run the program, we shouldn't have to stop the program and ask them to install uv. We should try and install uv in this launcher before we run the program. (Hard requirements)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two variables declared in shell script file, but not used anywhere in the code. Simplified UV handling command, we can install UV for them if they're asking us to run this launcher.
What does this change?
For Developers: Reduces the number of line to read and debug through.
For Clients: Reduces memory allocation for the unused declared variables.
How was it tested?
Ran
uv run pytest && uv run ruff check && uv run ruff format --check./CorridorKey_DRAG_CLIPS_HERE_local.sh '~/Documents/Video/'(For what it's worth, no python code was changed in this PR. Only a shell cleanup)
Checklist
uv run pytestpassesuv run ruff checkpassesuv run ruff format --checkpasses