Skip to content

fix: unescape FEEL string literal escape sequences#81

Merged
nikku merged 2 commits intonikku:mainfrom
bpmn-io:issue-88
Mar 13, 2026
Merged

fix: unescape FEEL string literal escape sequences#81
nikku merged 2 commits intonikku:mainfrom
bpmn-io:issue-88

Conversation

@barinali
Copy link
Contributor

Related to bpmn-io/variable-resolver#88

Proposed Changes

This pull request aims to "unescape" escape sequences for string literals so that upstreams do not double-serialize/encode string literals.

Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a test case for escaped newline. In the context of Camunda, we should be also able to handle newline characters. Added a test case for that too.

@barmac
Copy link
Contributor

barmac commented Mar 13, 2026

@nikku We need a review from your side :)

@nikku
Copy link
Owner

nikku commented Mar 13, 2026

Thanks! Update with mixed escape test and changelog update.

@nikku nikku merged commit b55f0f4 into nikku:main Mar 13, 2026
1 check passed
@nikku nikku deleted the issue-88 branch March 13, 2026 16:02
@nikku
Copy link
Owner

nikku commented Mar 13, 2026

Released as v2.3.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants