[Enhancement]Added a metric for geo replication for tracking replicated subscriptions snapshot timeouts#3
Conversation
2 tasks
nikam14
changed the title
…gerStorage and enable multiple ManagedLedgerFactory instances (apache#23313)
…oup until they are fixed (apache#23414)
…TO_SPLIT ordered mode (apache#23423)
…on of Key_Shared / Shared with feature flag (apache#23424)
…bilityDifferentBrokersForNonPersistentTopic (apache#23259)
Co-authored-by: Masahiro Sakamoto <massakam@yahoo-corp.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#21793
Motivation
Geo replication replicated subscriptions (PIP-33) snapshot creation might time out.
The code contains a debug log message when this happens
When this happens, the subscription state won't be reflected on the remote side and a backlog would build up.
There's no metric to detect this situation.
Modifications
Add a new metric
pulsar_replicated_subscriptions_snapshot_timeoutswhich is a counter (that only resets when the broker restarts).Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: