feat(scanner): add retry on timeout to reduce false negatives #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
would otherwise be falsely rejected
response) fail immediately
Details
ScanRetriesconstant (1 retry = 2 total attempts per IP)isTimeout()helper checks bothnet.Errorinterface and string matchingTest plan
TestE2ERetryOnTimeout— flaky server drops 1st request, retry recoversTestE2ERetryExhausted— all retries fail, IP correctly rejectedTestE2ERetryDomainVerification— A-record retry + TXT passesTestE2ERetryDomainVerificationTXTTimeout— both A and TXT retry via alternating-dropserver
TestIsTimeout— unit test for timeout detection