Replace Windows-reserved characters in test fixture filenames with URL encoding

[Copilot]

Test fixture files contained ? and & in filenames to represent HTTP query parameters, preventing repository checkout on Windows where these are reserved characters.

Changes

• Test fixtures: Renamed 12 files using URL encoding scheme:

  • ? → ___ (query separator)
  • & → %26 (URL-encoded)

  Example: GetInverterRealtimeData.cgi?Scope=Device&DeviceId=0 → GetInverterRealtimeData.cgi___Scope=Device%26DeviceId=0

• Mock server: Updated translate_path() to URL-encode query strings after unquoting incoming requests:

  # Before: Simple string replacement (vulnerable to injection)
  path = path.replace("?", "___").replace("&", "__")
  
  # After: Proper URL encoding (secure)
  path = urllib.parse.unquote(path)  # Standard HTTP behavior
  if "?" in path:
      base, query = path.split("?", 1)
      path = f"{base}___{urllib.parse.quote(query, safe='=')}"

This prevents crafted URLs like /api___param=value from bypassing the encoding to access unintended test fixtures.

• CI/CD: Updated GitHub Actions workflow:
  • Added Windows (Python 3.12) to the test matrix to verify Windows compatibility
  • Added continue-on-error: true to coveralls upload step to prevent workflow failures when the service is unavailable

Testing

• ✅ All 31 tests pass on Ubuntu (Python 3.8-3.13)
• ✅ Tests will run on Windows (Python 3.12) in CI to verify compatibility
• ✅ No Windows-reserved characters in filenames
• ✅ Security verified: crafted URLs cannot access unintended files
• ✅ Coveralls upload failures won't block the workflow

Original prompt

---

This section details on the original issue you should resolve

<issue_title>No checkout on Windows possible - Question marks in unittest files</issue_title>
<issue_description>Hi,

right now, it is not possible to develop, test or use the repository on Windows (11).

The cloning itself works, but the main branch cannot be checked out, it fails with Clone succeeded, but checkout failed.

This is due to the question marks in the unittest files, e.g., pyfronius\tests\test_structure\v0\solar_api\GetInverterRealtimeData.cgi?Scope=Device&DeviceIndex=1&DataCollection=CommonInverterData

A question mark is a reserved character on Windows that cannot be contained in paths (see e.g., here or more generally here).

Would it be possible to refactor them?

Thanks in advance! 🙂 </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes No checkout on Windows possible - Question marks in unittest files #30

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[nielstron]

LGTM

[nielstron]

@copilot two things

1. make sure that a coveralls upload error in the CI does not fail the workflow
2. add windows runs to the execution matrix (just one python version) to make sure it really works on windows

[Copilot]

@copilot two things

1. make sure that a coveralls upload error in the CI does not fail the workflow
2. add windows runs to the execution matrix (just one python version) to make sure it really works...

Done in commit a2776f8:

1. Added continue-on-error: true to the coveralls upload step to prevent workflow failures
2. Added Windows (Python 3.12) to the test matrix alongside all existing Ubuntu/Python combinations

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	distlib@​0.4.0
	pre-commit@​4.5.0
	coverage@​7.13.0
	pygments@​2.19.2
	chardet@​5.2.0
	identify@​2.6.15
	packaging@​25.0
	aiohappyeyeballs@​2.6.1
	typing-extensions@​4.15.0
	pyyaml@​6.0.3
	attrs@​25.4.0
	platformdirs@​4.5.1
	iniconfig@​2.3.0
	cfgv@​3.5.0
	async-timeout@​5.0.1
	tomli@​2.3.0
	pluggy@​1.6.0
	colorama@​0.4.6
	frozenlist@​1.8.0
	filelock@​3.20.0
	propcache@​0.4.1
	idna@​3.11
	cachetools@​6.2.2

View full report