Made changes for C++, general usability#5
Open
samgubernick wants to merge 1 commit intonicolausYes:masterfrom
Open
Made changes for C++, general usability#5samgubernick wants to merge 1 commit intonicolausYes:masterfrom
samgubernick wants to merge 1 commit intonicolausYes:masterfrom
Conversation
-Added regular functions and namespaces -Removed <map> dependency from easing.cpp -Added decimals to whole numbers (1, 2, ... are now 1.0, 2.0, ...) -Changed types to auto -Removed leading and trailing spaces
|
|
||
| #ifndef EASING_EASING_HPP_INCLUDED | ||
| #define EASING_EASING_HPP_INCLUDED | ||
| #pragma once |
There was a problem hiding this comment.
Any specific reason to have both the ifndef guard and the pragma once?
|
Source: https://stackoverflow.com/questions/1143936/pragma-once-vs-include-guards Using the two together you get the best of each compiler for this. (I didnt know as well, but now I do :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Moved dynamic easing functions to dedicated file
-Added regular functions and namespaces
-Removed dependency from easing.cpp (now in easing_dynamic.cpp)
-Added decimals to whole numbers (1, 2, ... are now 1.0, 2.0, ...)
-Changed types to auto
-Removed leading and trailing spaces
-Changed header file format to .hpp
-Changed lowercase class names to capitalized first letter of words
-Added include guards
-Changed easing enum to enum class