Open
Conversation
nicolas-goudry
force-pushed
the
feat/add-trivy
branch
from
5822e11 to
b0cdf73
Compare
- add error handling with trap - add input validation - add better error reporting - move code to functions - use readonly vars for config - add colored logging - add progress indicators - report successful vs failed scans - validate files before processing - add comprehensive comments and function documentation
nicolas-goudry
force-pushed
the
feat/add-trivy
branch
from
b0cdf73 to
53f2757
Compare
nicolas-goudry
force-pushed
the
feat/add-trivy
branch
from
bdf36e7 to
6482b2e
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a code scanning workflow using Trivy to scan container images for vulnerabilities and uploads SARIF reports to GitHub Code Scanning.
🚀 Features
scriptsdirectory, containing runnable scripts which are added to thepackagesFlake output as well as automatically loaded in development shell✨ Changes
imageandtagattributes, respectively containing the image derivation (which was previously returned in place of the attrset) and the image tag which matches the derivation inimagefromImageattribute withlib.optionalStringinstead of anif ... then ... elseconditionnix2containerinput ton2ceachSystemto send an attribute set containingpkgs,xpkgs(local packages) as well asnix2containerto callers (previously only sendingpkgs)shell.nix🤖 CI
code-scanningworkflow to trigger Trivy scanning on pull requests as well as on a successful release and upload SARIF results to GitHub Code Scanningrepository_dispatchtrigger is removed from other workflows.scriptsdirectory