Skip to content
This repository was archived by the owner on Jul 13, 2024. It is now read-only.

Fix yarn install#421

Merged
nicoespeon merged 1 commit intonicoespeon:masterfrom
aicioara-forks:aic-fix-yarn-install
Sep 26, 2022
Merged

Fix yarn install#421
nicoespeon merged 1 commit intonicoespeon:masterfrom
aicioara-forks:aic-fix-yarn-install

Conversation

@aicioara
Copy link
Collaborator

@aicioara aicioara commented Sep 25, 2022

The Problem

$ yarn install
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
warning url-loader@1.1.2: Invalid bin field for "url-loader".
warning webpack-hot-client@4.1.1: Invalid bin field for "webpack-hot-client".
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/nicoespeon/mdx-deck.git
Directory: [redacted]/gitgraph.js
Output:
fatal: unable to connect to github.com:
github.com[0: 192.30.255.113]: errno=Operation timed out
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Steps to reproduce

In order to reproduce, you must first clean your yarn cache, otherwise, the dependency will resolve locally

git clean -xfd # Deletes installation
npm cache clean
npm cache clean --force
yarn cache clean
yarn cache clean --mirror

The actual problem is that GitHub deprecated git:// as of March 2022. Read more about it here https://blog.readthedocs.com/github-git-protocol-deprecation

Reproduce just that part using

ls-remote --tags --heads git://github.com/nicoespeon/mdx-deck.git

Workaround

You can workaround without this patch using the git config command below

git config --global url."https://".insteadOf git://

However, figuring that out and finding the article used 30 minutes of my time, so I hope this PR will save other people.

Related Work

This change is also part of #419

This PR is part of a larger set of changes that are needed in order to build the project reliably. See aicioara-forks#1 for a heads-up. I want to clean up that PR and open it up for review in smaller pieces

Copy link
Collaborator

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first PR. A well articulated explanation for the changes - good work all around!

@aicioara
Copy link
Collaborator Author

Thank you @crutchcorn . Is it expected that continuous-integration/travis-ci takes 3+ hours to complete?

@crutchcorn
Copy link
Collaborator

@nicoespeon sorry to bother - could you take a look at what's going on with GH actions here?

@crutchcorn
Copy link
Collaborator

I think the repo settings are configured wrong.

@nicoespeon
Copy link
Owner

Sure thing! I'm quite busy but I'll def. have a look today. Shouldn't be too hard (famous last words) 😉

@nicoespeon
Copy link
Owner

@crutchcorn that was a trivial fix indeed. Travis evolved over time and the name of the action changed somehow. I fixed the requirements and we are all good now!

@aicioara thank you very much! I'm not really maintaining this anymore, but I'll be supportive to help you ramp up as a maintainer if you want to 😉 I just have a talk to give this week, so quite busy these days… but I'll get back to your comment in the other issue. Thanks for your contributions in any case, they are welcome!

@nicoespeon nicoespeon merged commit 981cdbd into nicoespeon:master Sep 26, 2022
@nicoespeon
Copy link
Owner

@all-contributors please add aicioara to infrastructure

@allcontributors
Copy link
Contributor

@nicoespeon

I've put up a pull request to add @aicioara! 🎉

@aicioara
Copy link
Collaborator Author

Thank you. I appreciate the kind words. More PRs to come.

@aicioara aicioara deleted the aic-fix-yarn-install branch September 27, 2022 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants