Conversation
crutchcorn
left a comment
There was a problem hiding this comment.
Good first PR. A well articulated explanation for the changes - good work all around!
|
Thank you @crutchcorn . Is it expected that |
|
@nicoespeon sorry to bother - could you take a look at what's going on with GH actions here? |
|
I think the repo |
|
Sure thing! I'm quite busy but I'll def. have a look today. Shouldn't be too hard (famous last words) 😉 |
|
@crutchcorn that was a trivial fix indeed. Travis evolved over time and the name of the action changed somehow. I fixed the requirements and we are all good now! @aicioara thank you very much! I'm not really maintaining this anymore, but I'll be supportive to help you ramp up as a maintainer if you want to 😉 I just have a talk to give this week, so quite busy these days… but I'll get back to your comment in the other issue. Thanks for your contributions in any case, they are welcome! |
|
@all-contributors please add aicioara to infrastructure |
|
I've put up a pull request to add @aicioara! 🎉 |
|
Thank you. I appreciate the kind words. More PRs to come. |
The Problem
Steps to reproduce
In order to reproduce, you must first clean your
yarncache, otherwise, the dependency will resolve locallygit clean -xfd # Deletes installation npm cache clean npm cache clean --force yarn cache clean yarn cache clean --mirrorThe actual problem is that GitHub deprecated
git://as of March 2022. Read more about it here https://blog.readthedocs.com/github-git-protocol-deprecationReproduce just that part using
Workaround
You can workaround without this patch using the git config command below
git config --global url."https://".insteadOf git://However, figuring that out and finding the article used 30 minutes of my time, so I hope this PR will save other people.
Related Work
This change is also part of #419
This PR is part of a larger set of changes that are needed in order to build the project reliably. See aicioara-forks#1 for a heads-up. I want to clean up that PR and open it up for review in smaller pieces